Simplistic method to detect possible undefined vars #8797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonme
commented
Jun 24, 2023
| @@ -0,0 +1,21 @@ | |||
| """module docstring""" | |||
There was a problem hiding this comment.
both these test files are only to ease debugging, will be deleted
for more information, see https://pre-commit.ci
|
Hi @alonme thanks for this. In #1727 (comment) I was suggesting something along the lines of this, did you investigate it yet? It fixes the issue but haven't checked the test suite or the primer result. diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py
index 3ea2d04a5..ab7ed9618 100644
--- a/pylint/checkers/variables.py
+++ b/pylint/checkers/variables.py
@@ -735,13 +735,13 @@ scope_type : {self._atomic.scope_type}
# Only search else branch when test condition is inferred to be false
if all_inferred and only_search_else:
return NamesConsumer._branch_handles_name(name, node.orelse)
- # Only search if branch when test condition is inferred to be true
- if all_inferred and only_search_if:
- return NamesConsumer._branch_handles_name(name, node.body)
+ # # Only search if branch when test condition is inferred to be true
+ # if all_inferred and only_search_if:
+ # return NamesConsumer._branch_handles_name(name, node.body)
# Search both if and else branches
return NamesConsumer._branch_handles_name(
name, node.body
- ) or NamesConsumer._branch_handles_name(name, node.orelse)
+ ) and NamesConsumer._branch_handles_name(name, node.orelse)
@staticmethod
def _branch_handles_name(name: str, body: Iterable[nodes.NodeNG]) -> bool: |
|
Closing in favor of #8952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #1727