-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #8803
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8803 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 173 173
Lines 18510 18510
=======================================
Hits 17750 17750
Misses 760 760
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems off with this optional added because of the | None
Should we fix all of the https://beta.ruff.rs/docs/rules/mutable-class-default/, what do you think @DanielNoord ? |
I like it, but we might get into trouble for stuff like: class FunctionDef:
node_assigned_in_post_init: NodeNG It feels as if they might start asking for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's deal with this in another issue or not at all, there's no reason to block the pre-commit upgrade indefinitely.
0007a88
to
18a3a64
Compare
updates: - [github.com/charliermarsh/ruff-pre-commit: v0.0.272 → v0.0.275](astral-sh/ruff-pre-commit@v0.0.272...v0.0.275) - [github.com/pre-commit/mirrors-mypy: v1.3.0 → v1.4.1](pre-commit/mirrors-mypy@v1.3.0...v1.4.1)
18a3a64
to
9b7dbcc
Compare
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 9b7dbcc |
updates: