Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #8803

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #8803 (9b7dbcc) into main (bf8051b) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8803   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         173      173           
  Lines       18510    18510           
=======================================
  Hits        17750    17750           
  Misses        760      760           
Impacted Files Coverage Δ
pylint/checkers/base/name_checker/checker.py 98.59% <ø> (ø)
pylint/checkers/similar.py 96.28% <ø> (ø)
pylint/checkers/utils.py 95.76% <ø> (ø)
pylint/checkers/variables.py 97.25% <100.00%> (ø)
pylint/pyreverse/diagrams.py 92.16% <100.00%> (ø)
pylint/pyreverse/writer.py 100.00% <100.00%> (ø)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems off with this optional added because of the | None

@Pierre-Sassoulas Pierre-Sassoulas added dependency Label for github dependabot Skip news 🔇 This change does not require a changelog entry labels Jun 27, 2023
@Pierre-Sassoulas
Copy link
Member

Should we fix all of the https://beta.ruff.rs/docs/rules/mutable-class-default/, what do you think @DanielNoord ?

@DanielNoord
Copy link
Collaborator

Should we fix all of the https://beta.ruff.rs/docs/rules/mutable-class-default/, what do you think @DanielNoord ?

I like it, but we might get into trouble for stuff like:

class FunctionDef:
    node_assigned_in_post_init: NodeNG

It feels as if they might start asking for ClassVar there as well, and then we can't acutally assign it later on.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deal with this in another issue or not at all, there's no reason to block the pre-commit upgrade indefinitely.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 1da5183 into main Jul 1, 2023
38 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ci-update-config branch July 1, 2023 10:55
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 9b7dbcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Label for github dependabot Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants