[doc] Stable generation of all options across interpreters #8951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Documentation 📗
Work in progress
Skip news 🔇
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8951 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 173 173
Lines 18557 18557
=======================================
Hits 17767 17767
Misses 790 790 |
This comment has been minimized.
This comment has been minimized.
DanielNoord
previously approved these changes
Aug 13, 2023
Pierre-Sassoulas
force-pushed
the
stable-generation-of-option-across-interpreters
branch
from
a88701b
to
4fc96c1
Compare
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
force-pushed
the
stable-generation-of-option-across-interpreters
branch
from
240f488
to
c9640fe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 7044099 |
Pierre-Sassoulas
force-pushed
the
stable-generation-of-option-across-interpreters
branch
from
232b52a
to
e168310
Compare
Pierre-Sassoulas
added a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Aug 15, 2023
The comparison was not done properly for extension when the second values given was a builtin and the first one an extension. The tests were not testing this case properly because the alphabetical order made us think that everything went right. Added a test with a low value extension checker. Necessary for pylint-dev#8951
Pierre-Sassoulas
added a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Aug 15, 2023
The comparison was not done properly for extension when the second values given was a builtin and the first one an extension. The tests were not testing this case properly because the alphabetical order made us think that everything went right. Added a test with a low value extension checker. Necessary for pylint-dev#8951
Pierre-Sassoulas
force-pushed
the
stable-generation-of-option-across-interpreters
branch
from
cedfa4c
to
9b0075f
Compare
|
Depends on #8956 |
Pierre-Sassoulas
added
Blocked 🚧
Pierre-Sassoulas
added a commit
that referenced
this pull request
Aug 15, 2023
The comparison was not done properly for extension when the second values given was a builtin and the first one an extension. The tests were not testing this case properly because the alphabetical order made us think that everything went right. Added a test with a low alphabetical value extension checker. Necessary for #8951
Pierre-Sassoulas
force-pushed
the
stable-generation-of-option-across-interpreters
branch
from
9b0075f
to
b7866c5
Compare
Pierre-Sassoulas
force-pushed
the
stable-generation-of-option-across-interpreters
branch
from
b7866c5
to
ffe6b45
Compare
DanielNoord
approved these changes
Aug 15, 2023
Pierre-Sassoulas
deleted the
stable-generation-of-option-across-interpreters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Necessary for #6736, require #8956