Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI jobs to 3.12 #9092

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Bump CI jobs to 3.12 #9092

merged 3 commits into from
Oct 11, 2023

Conversation

jacobtylerwalls
Copy link
Member

No description provided.

@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Oct 2, 2023
@Pierre-Sassoulas
Copy link
Member

I'm not sure we have to make the default python interpreter 3.12 yet, but we should test our code on the actual 3.12 not 3.12 dev

@mbyrnepr2
Copy link
Member

mbyrnepr2 commented Oct 3, 2023

Error: The version '3.12' with architecture 'x64' was not found for Ubuntu 22.04.
17
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

And another, the ReadTheDocs message:
Problem in your project's configuration. Invalid configuration option "build.tools.python": expected one of (2.7, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11, 3, miniconda3-4.7, mambaforge-4.10, mambaforge-22.9), got 3.12

@jacobtylerwalls jacobtylerwalls added the Blocked 🚧 Blocked by a particular issue label Oct 3, 2023
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to leave the review when I was on mobile.

.github/workflows/checks.yaml Outdated Show resolved Hide resolved
@jacobtylerwalls
Copy link
Member Author

(Primer will remain failing until we get a 3.12 run on main.)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #9092 (6267f03) into main (3cba15b) will increase coverage by 0.00%.
Report is 13 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9092   +/-   ##
=======================================
  Coverage   95.75%   95.76%           
=======================================
  Files         173      173           
  Lines       18663    18665    +2     
=======================================
+ Hits        17871    17874    +3     
+ Misses        792      791    -1     

see 2 files with indirect coverage changes

@mbyrnepr2
Copy link
Member

3.12 action is available now right? https://github.com/actions/python-versions

@mbyrnepr2
Copy link
Member

Do we want to add 3.12 to the tox.ini while we're here?

@Pierre-Sassoulas Pierre-Sassoulas merged commit f8a0c6c into main Oct 11, 2023
35 of 44 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the ci-312 branch October 11, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked 🚧 Blocked by a particular issue Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants