Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/3.0.x] Respect py-version for inconsistent-quotes inside f-strings #9155

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport 1c0bc70 from #9152.

* [inconsistent-quotes] Emit for f-strings for 3.12 only

* Add docs for inconsistent-quotes with f-strings

Despite ``sys.version`` check, pylint raises the warning
with Python 3.11

(cherry picked from commit 1c0bc70)
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Oct 16, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.2 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #9155 (1ec96bd) into maintenance/3.0.x (a9d9dc3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.0.x    #9155   +/-   ##
==================================================
  Coverage              95.76%   95.76%           
==================================================
  Files                    173      173           
  Lines                  18676    18686   +10     
==================================================
+ Hits                   17885    17895   +10     
  Misses                   791      791           
Files Coverage Δ
pylint/checkers/strings.py 94.27% <100.00%> (+0.13%) ⬆️

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) October 16, 2023 14:24
@Pierre-Sassoulas Pierre-Sassoulas merged commit a77f0c1 into maintenance/3.0.x Oct 16, 2023
25 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-9152-to-maintenance/3.0.x branch October 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants