Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FAQ): Update duplicated messages in pycodestyle #9384

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

baco
Copy link
Contributor

@baco baco commented Jan 23, 2024

Added a missing message that duplicates behavior in pycodestyle to the FAQ.

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

Refs #3512, #746

Closes #9383

Added a missing message that duplicates behavior in `pycodestyle` to the FAQ.
@Pierre-Sassoulas Pierre-Sassoulas added Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry labels Jan 23, 2024
doc/faq.rst Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas changed the title feat(FAQ): Update duplicated messages in other linters feat(FAQ): Update duplicated messages in pycodestyle Jan 23, 2024
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, keeping this list up to date is hard work πŸ˜„

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) January 23, 2024 21:09
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (4ffbc72) 95.81% compared to head (30d2616) 95.81%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9384   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         173      173           
  Lines       18772    18772           
=======================================
  Hits        17986    17986           
  Misses        786      786           

@baco
Copy link
Contributor Author

baco commented Jan 23, 2024

Actually, I had change the order to honor ordering by code letter and number: (Warnings first as more important, then Conventions). And the numbers, well, the numbers.

But I guess I didn't notice the style in documentation was alphabetical instead.

@baco
Copy link
Contributor Author

baco commented Jan 23, 2024

Thank you for the contribution, keeping this list up to date is hard work πŸ˜„

Indeed. I stumbled upon by chance because my editor highlighted them both.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 51c28bc into pylint-dev:main Jan 23, 2024
26 checks passed
@baco baco deleted the faq-avoid-duplicates branch January 23, 2024 21:20
@Pierre-Sassoulas
Copy link
Member

Congratulation on becoming a pylint contributor πŸš€ ! The doc is upgraded as soon as it's merged so your change is live :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[documentation] Missing disable message for avoiding duplicates
2 participants