[Backport maintenance/3.2.x] Fix crash in refactoring checker when calling bound lambda #9867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
changed the title
Fixes:
```
File "sources/pylint/pylint/checkers/refactoring/refactoring_checker.py", line 2094, in _is_function_def_never_returning
and node.returns
^^^^^^^^^^^^
File "sources/pylint/.venv/lib/python3.11/site-packages/astroid/bases.py", line 138, in __getattr__
return getattr(self._proxied, name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Lambda' object has no attribute 'returns'
```
Crash is reproducible if you have something like this:
```python
class C:
eq = lambda self, y: self == y
```
As a workaround, use a normal function instead of a lambda.
Closes pylint-dev#9865
(cherry picked from commit b78deb6)
jacobtylerwalls
force-pushed
the
backport-9866-to-maintenance/3.2.x
branch
from
3ff6ca7
to
930ad78
Compare
Pierre-Sassoulas
approved these changes
Aug 11, 2024
jacobtylerwalls
merged commit f1925f4
into
pylint-dev:maintenance/3.2.x
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of b78deb6 from #9866