Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9959: Update FAQ, with tweaks suggested by Grammarly #9960

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

edreamleo
Copy link
Contributor

@edreamleo edreamleo commented Sep 24, 2024

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

Update FAQ per #9959. (Closes #9959)

  • Change title of FAQ section.
  • Revise FAQ section.

@Pierre-Sassoulas Pierre-Sassoulas added Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.80%. Comparing base (30ae33f) to head (bf0c214).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9960   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         174      174           
  Lines       18940    18940           
=======================================
  Hits        18146    18146           
  Misses        794      794           

doc/faq.rst Outdated
Pylint will never be fast enough to run on every keystroke.

However, IDEs could run pylint automatically *in the background*
when the IDE saves changed Python files. Contact your IDE with a support request :-)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should link to the vs code plugin, they've already added a lot of tooling for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtylerwalls Good idea. I'll update the PR later today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when the IDE saves changed Python files. Contact your IDE with a support request :-)
when the IDE saves changed Python files.

Some IDE do it already, some do not and might not like the influx of requests, let's remove the advice.

@jacobtylerwalls jacobtylerwalls linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, some nits from me!

doc/faq.rst Outdated
@@ -67,12 +67,16 @@ to not be included as default messages.
You can see the plugin you need to explicitly :ref:`load in the technical reference
<user_guide/checkers/extensions:optional checkers>`.

I want to use pylint on each keystroke in my IDE, how can I do that ?
---------------------------------------------------------------------
I want to use run pylint automatically in my IDE. How do I do that?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
I want to use run pylint automatically in my IDE. How do I do that?
I want to run pylint on each keystroke in my IDE. How do I do that?

Automatically is not a problem, each keystroke though is.

doc/faq.rst Outdated
Pylint will never be fast enough to run on every keystroke.

However, IDEs could run pylint automatically *in the background*
when the IDE saves changed Python files. Contact your IDE with a support request :-)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when the IDE saves changed Python files. Contact your IDE with a support request :-)
when the IDE saves changed Python files.

Some IDE do it already, some do not and might not like the influx of requests, let's remove the advice.

doc/faq.rst Outdated
integration job or a git ``pre-push`` hook for big projects. The larger your repository
Pylint will never be fast enough to run on every keystroke.

However, IDEs could run pylint automatically *in the background*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, IDEs could run pylint automatically *in the background*
However, IDEs could run pylint automatically on the single file you're working on or in the background

@edreamleo
Copy link
Contributor Author

@Pierre-Sassoulas Thanks for your suggestions. Please review the changes at rev 96986d2.

doc/faq.rst Outdated Show resolved Hide resolved
doc/faq.rst Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member

Thank you for making the doc better / more nuanced !

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) September 24, 2024 19:59
@Pierre-Sassoulas Pierre-Sassoulas merged commit 88e4bc6 into pylint-dev:main Sep 24, 2024
26 checks passed
@edreamleo edreamleo deleted the ekr-9959-faq branch September 24, 2024 20:15
@edreamleo
Copy link
Contributor Author

@Pierre-Sassoulas Thanks for your help and guidance :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ: it *is* possible to run pylint automatically
3 participants