Suggest disabling ungrouped-imports in FAQ when using isort
#9976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isort` can be pretty flexible about grouping the imports, and sometimes its configuration may be incompatible with not only `wrong-imports-order` but with the `ungrouped-imports` rule too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9976 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18940 18940
=======================================
Hits 18146 18146
Misses 794 794 |
Pierre-Sassoulas
added
Documentation 📗
Skip news 🔇
webknjaz
added a commit
to webknjaz/ansible--awx-plugins
that referenced
this pull request
Sep 29, 2024
They are handled by `isort` already and it is way more flexible than PyLint, which reports false-positives. Refs: * pylint-dev/pylint#9976 * pylint-dev/pylint#9977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isortcan be pretty flexible about grouping the imports, and sometimes its configuration may be incompatible with not onlywrong-imports-orderbut with theungrouped-importsrule too.Type of Changes
Description
$sbj. This is inspired by #9977.