-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut ScopeConsumer #9995
Cut ScopeConsumer #9995
Conversation
This class is only used by the NamesConsumer. It adds an extra level of indirection, but without providing any clear benefit.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9995 +/- ##
==========================================
- Coverage 95.80% 95.80% -0.01%
==========================================
Files 174 174
Lines 18946 18937 -9
==========================================
- Hits 18152 18143 -9
Misses 794 794
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 881c8a1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will give this a look and an approval later, but just noting quickly I find this a welcome refactor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The
ScopeConsumer
class is only used by theNamesConsumer
. It adds an extra level of indirection, but without providing any clear benefit. Cut it and incorporate its fields directly intoNamesConsumer
.