Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privacy.clearOnShutdown.passwords was removed in Firefox 42 #290

Closed
1 task
nodiscc opened this issue May 5, 2017 · 4 comments
Closed
1 task

privacy.clearOnShutdown.passwords was removed in Firefox 42 #290

nodiscc opened this issue May 5, 2017 · 4 comments

Comments

@nodiscc
Copy link
Contributor

nodiscc commented May 5, 2017

https://hg.mozilla.org/releases/mozilla-esr45/rev/fb4f42bbeb01

  • move it to ignore.list
@pyllyukko
Copy link
Owner

Should I keep letting you know things like this?

Your input is always much appreciated!

Still want to point out, that we want the "hard facts" of the removal of any settings before removing it from the user.js.

@pyllyukko
Copy link
Owner

I fully understand what "hidden" prefs are (from the contributing#removed-settings) and I do appreciate it is nice to have an actual source. That said, I always check DXR (and before that MXR). I use the mozilla-central branch FYI. And I always test. I am thorough. I don't believe everything I read, I always investigate. But I am not going back 2 or 3 years or more to find old bugzillas if they exist - some in the past have been impossible to find.

For this project, it's not "nice to have", it's mandatory. I know that you're thorough, it's not about that and you shouldn't interpret it as distrust against your word.

FYI: here is one https://bugzilla.mozilla.org/show_bug.cgi?id=449596 browser.sessionstore.enabled was removed 9 years ago in FF 3.1a2

Thanks!

@nodiscc
Copy link
Contributor Author

nodiscc commented May 22, 2017

going back 2 or 3 years or more to find old bugzillas if they exist

@Thorin-Oakenpants yeah this is a chore, searching on https://hg.mozilla.org/mozilla-central/ can help a lot when looking for a particular change (an equivalent would be hg clone https://hg.mozilla.org/mozilla-central/ and searching the log with hg log...). Whereas DXR only shows the codebase at a set point (tip/release/esr52/esr45/esr31...), you have to manually switch branches/use Blame to find changes...

For example searching for https://hg.mozilla.org/mozilla-central/log?rev=browser.sessionstore.enabled shows that it was removed in https://hg.mozilla.org/mozilla-central/rev/e712e96d7861 (there's also a link to bug 449596 in that commit message). Easier than digging bugzilla or DXR. (Though the pref name must be in the commit message).

hg.mozilla.org has a log dating back to Firefox 3.5 (release branch mozilla-1.9.1, July 2011).

browser.urlbar.maxRichResults

@pyllyukko removed it in 116d986 but wrongly, I believe, it does have the effect I describe (doesn't it?), please check the commit comment if you have time.

browser.download.manager.retention

Still present in ESR45, 52, and in the current release (53), not there anymore in the latest firefox-central revision (unreleased). What is wrong about it? (another issue?)

I agree with @pyllyukko that facts based on actual code changes are very important to me (user testing can sometimes be misleading - I think I just sent a patch for the wrong pref in #300 ).

The underlying problem is that Mozilla has no documentation for what the prefs do. It would make things much easier to maintain. Might be worth opening a bugzilla ticket and and asking the maintainers if they'd like the idea.

@pyllyukko
Copy link
Owner

You guys are both watching the ghacks repo, but said nothing when all these were brought up.

What "these" are you exactly referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants