Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk cache: add 2 commented out prefs for reference #214

Closed
wants to merge 3 commits into from
Closed

disk cache: add 2 commented out prefs for reference #214

wants to merge 3 commits into from

Conversation

nodiscc
Copy link
Contributor

@nodiscc nodiscc commented Feb 25, 2017

Fixes item 1001 in #208

@pyllyukko
Copy link
Owner

I think this needs some additional researching and links in the user.js. Sounds like something that browser.cache.disk.enable already handles.

@nodiscc
Copy link
Contributor Author

nodiscc commented Feb 28, 2017

Added documentation

@pyllyukko
Copy link
Owner

Still... do we need these at all? Smart or dumb, the disk cache isn't in use and that can be verified from about:cache:

Number of entries: 	0
Maximum storage size: 	32768 KiB
Storage in use: 	0 KiB
Storage disk location: 	none, only stored in memory 

Of course there's the "When disk cache is enabled" note, but is it unnecessary clutter?

@nodiscc
Copy link
Contributor Author

nodiscc commented Feb 28, 2017

You are right. Closing, feel free to mark #208 item 1001 as fixed (#214)

@pyllyukko
Copy link
Owner

Done.

@nodiscc nodiscc deleted the patch-9 branch March 14, 2017 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants