README: refactor addons section; other fixes; fix GEOLOCATION/QUIET FOX sections of #208 #255

nodiscc · 2017-03-25T10:44:56Z

See commit messages

nodiscc · 2017-03-25T13:30:30Z

Done with this part. Let me know if this should be split into separate PRs.

link to mozilla meta tracking page for this pref change pref description since this is related to more than screen size and media queries

* remove lengthy description, just recommend addons, or don't recommend them. * remove duckduckgo plus, add generic hardening recommendation about privacy-conscious search engines * store all addon-specific recommendations in the addon section * Move ghostery to Other addons subsection, add uMatrix to this section * remove links to issues (use the search feature) * move built-in tracking protection links to user.js tracking protection section * run make - auto-update 'What does it do' section

…pecific recommendations

…3 0204 of #208 more accurate description of accept_language setting

…s item 0208 of #208

…when enabled, fixes items 0309 0310 of #208

see https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#1350 set experiments manifest uri to blank, even though experiments are already disabled; update previously broken links in experiments/telemetry section fixes item 0340 of #208

…0305 of #208

… don't nag user about unsent crash reports: fixes items 0350 0351 of #208

…ments

README: * add fingerprinting mitigation to project goals * add optional user.js customization to usage steps * reorder system wide installation section (os specific steps at the end) * add generic hardening recommendations regarding password policy/open-source software/plain-text communications/tor usage * issues: add generic organization guideline * add firefox about: urls doc link user.js: * add notice about webrtc breaking p2p file transfer methods * make affected Firefox versions consistent

* detect preferences that are no longer present in firefox source target firefox version is configurable mozilla test suite prefs files are included for completeness sake * detect Firefox preferences not covered by user.js preferences that should we don't want to modify should be listed in ignore.list add a basic ignore.list * display stats on number of covered preferences * to use, run 'make tests' subtargets: downloadffprefs, checkdeprecated, stats, cleanup * add 'make tests' to travis script * run 'make authors' to generate an AUTHORS file, ordered by number of commits to add extra authors/credits, git commit --allow-empty --author="A U Thor <[email protected]>" TODO: add a .mailmap file to deduplicate authors with multiple email addresses Results of tests against lastest Firefox revision can be seen at: ................

Thorin-Oakenpants · 2017-03-28T08:03:47Z

@nodiscc : I see under this you listed a link for about: URLs

I find using about:about will display everything applicable to your profile.

Compared to the list at the URL, I am missing:

about:app-manager - deprecated
about:compartments - deprecated
about:customizing - deprecated
about:permissions - deprecated (although the page notes it was removed in FF45)
about:sync-progress - valid entry, I have never set up sync
about:reader - valid entry, I just have reader disabled

And here are six items (non-extension) not listed

about:checkerboard
about:debugging
about:devtools-toolbox
about:performance
about:profiles
about:serviceworkers

Might be better and easier to just use about:about in the readme, as it will always be current and correct regardless of version

nodiscc · 2017-03-28T14:09:26Z

Thanks, I edited https://developer.mozilla.org/en-US/Firefox/The_about_protocol and asked for review. It's better to link to that page since it's the actual documentation on all about: pages. about:about: is listed there. I added a note that available about: pages may vary depending on Firefox versions.

Edit: page history https://developer.mozilla.org/en-US/Firefox/The_about_protocol$history

nodiscc · 2017-03-28T14:13:22Z

e92362c 093bd97 c0962da 24a5cfe c37bf58

README: update reference links, usage/installation/goals/hardening/FAQ doc (c0962da)
user.js: add a notice, cleanup
Makefile: add tests to detect deprecated/not covered prefs

Results of make tests introduced in c37bf58 can be seen at https://gist.github.com/nodiscc/ed0c84d3492e7faf8869ed52b5647dbd

Edit: also on travis: https://travis-ci.org/pyllyukko/user.js/builds/215770898

pyllyukko · 2017-03-28T20:44:18Z

AUTHORS

+Mehmet Atif Ergun <[email protected]>
+mengele-chan <[email protected]>
+uberspot <[email protected]>
+zummuz <[email protected]>


This is not needed. All the info is available as metadata.

pyllyukko · 2017-03-28T20:58:59Z

user.js

+
+// PREF: Disable Firefox Sync
+// https://wiki.mozilla.org/Services/Sync
+user_pref("services.sync.enabled",	false);


I don't think this is necessary, as it's opt-in and some users might actually want to use it.

pyllyukko · 2017-03-28T21:09:27Z

Will continue the review later, as I'm afraid I don't have the time to do it this week ☹️

pyllyukko · 2017-04-03T15:52:55Z

user.js

+
+// PREF: Don't use Mozilla-provided location-specific search engines
+user_pref("browser.search.geoSpecificDefaults", 	false);
+user_pref("browser.search.geoSpecificDefaults.url",	"");


Is the "" necessary, when the feature is toggled off?

Probably not, this can be moved to ignore.list

pyllyukko · 2017-04-03T17:57:40Z

Makefile

 	@./gen-readme.sh
+
+# To decrease tests verbosity, comment out unneeded targets
+tests: downloadffprefs checknotcovered checkdeprecated stats cleanup


This will fail horribly if you have e.g. MAKEFLAGS="-j 4", like I do.

I'm not entirely sure what is the proper way to fix it, as I'm not that familiar with makefiles. Maybe with .NOTPARALLEL?

Yes apparently a target named .NOTPARALLEL should inhibit the -j cli/config file option

Cool, that's what I thought. I'm still not sure as to where and how to add it.

e.g., should it be like:

.NOTPARALLEL: downloadffprefs

Or just as it's own line? It wasn't completely clear to me.

I forgot to post the link I found: http://stackoverflow.com/questions/4346399/how-can-i-force-gnu-make-to-not-build-recipe-in-parallel/23903293#23903293

.PHONY: all clean .NOTPARALLEL: anotherTarget: dependency1

Apparently on it's own line. The MAKEFLAGS variable can also be used (solution 3)

Yeah I saw that post also when I was looking at the subject. Is it so, that everything below that will not run as parallel or what? I mean there are still some things, that can be run as parallel in the makefile, e.g. authors, whatdoesitdo and all the rest for that matter, once downloadffprefs has finished.

Is it so, that everything below that will not run as parallel or what?

This is what it looks like, but I have no experience with parallel usage of Make - very interesting, I really need to read the full Make manual.

Unfortunately no time to work on it at the moment, would you be ok to apply the global MAKEFLAGS := --jobs=1 var, and open an issue (Makefile: parallelize tests) ? We can improve this later.

Sounds good.

pyllyukko · 2017-04-03T18:23:41Z

BTW. are you planning on pushing more commits into this? As I'm now tweaking it and trying to get it merged soon.

nodiscc · 2017-04-03T18:40:17Z

are you planning on pushing more commits into this

No, please edit it as you like; I will add commit comments on https://github.com/pyllyukko/user.js/commits/nodiscc-fixesfixesfixes if needed, or open other issues.

See #255 (review)

pyllyukko · 2017-04-03T21:37:09Z

Makefile

+	@# generate an AUTHORS file, ordered by number of commits
+	@# TODO: add a .mailmap file to deduplicate authors with multiple email addresses
+	@# to add extra authors/credits, git commit --allow-empty --author="A U Thor <[email protected]>"
+	@git shortlog -sne | cut -f1 --complement >| AUTHORS


BTW. would the following .mailmap file be sufficient for this?

CHEF-KOCH <[email protected]> <[email protected]> Francois Marier <[email protected]> <[email protected]>

Yes it works with these contents (I just tested it with git shortlog -sne)

I added it with 563c4c6. Even though I removed the AUTHORS file, but it's still better to get exact stats :)

One thing that is wrong here, is that there are so many people who have contributed through insights in issues & PRs, but haven't pushed any commits.

We would need to have yet-another-script that queries GitHub's API for all the people involved in here to have a complete list :)

As far as I know there is no way to (directly) list users who posted in a github project issue tracker. But it can be parsed from https://api.github.com/repos/pyllyukko/user.js/issues (login values). If you create a new issue for this, I'll have a look.

It was a joke, we don't need to do that :)

nodiscc mentioned this pull request Mar 26, 2017

Fingerprinting Firefox users with cached intermediate CA certificates #219

Closed

nodiscc changed the title ~~README: refactor addons section; other fixes~~ README: refactor addons section; other fixes; fix GEOLOCATION/QUIET FOX sections of #208 Mar 26, 2017

nodiscc added 20 commits March 26, 2017 18:51

improve comment-out referer spoofing prefs, closes #193

47bbbe5

simplify privacy.resistfingerprinting references:

cdf0bf5

link to mozilla meta tracking page for this pref change pref description since this is related to more than screen size and media queries

README: improve FAQ about deprecated preferences, closes #33 #251

311c51d

README: add-ons: add extra blocklists recommendation, shorten addon-s…

c850e47

…pecific recommendations

add intl.locale.matchOS and general.useragent.locale, fixes items 020…

70185dc

…3 0204 of #208 more accurate description of accept_language setting

add browser.search.geoSpecificDefaults* prefs, fixes item 0206 of #208

2e32077

Prevent leaking application locale/date format using JavaScript, fixe…

1eb9ec9

…s item 0208 of #208

opt-out of themes (persona) updates, fixes item 0307 of #208

a83b828

disable flash player crash reports, don't send URLs in crash reports …

33e9469

…when enabled, fixes items 0309 0310 of #208

Disable sending Firefox crash reports to Mozilla servers, fixes item …

c4db308

…0305 of #208

Disable sending reports of tab crashes to Mozilla (about:tabcrashed),…

6562602

… don't nag user about unsent crash reports: fixes items 0350 0351 of #208

disable flyweb, fixes item 0376 of #208

30c0965

disable Firefox SYnc, fixes item 0380 of #208

cef186b

run make - generate README 'What does it do' section from user.js com…

e92362c

…ments

README: credit ghacks-user.js in documentation section

093bd97

run make - update what does it do section

24a5cfe

pyllyukko reviewed Mar 28, 2017

View reviewed changes

pyllyukko reviewed Apr 3, 2017

View reviewed changes

pyllyukko added a commit that referenced this pull request Apr 3, 2017

Run make with 1 job

c91125c

See #255 (review)

pyllyukko added a commit that referenced this pull request Apr 3, 2017

Removed browser.search.geoSpecificDefaults.url

2a37932

See #255 (review)

pyllyukko merged commit c37bf58 into pyllyukko:master Apr 3, 2017

pyllyukko mentioned this pull request Apr 3, 2017

ghacks user.js monster diff #208

Closed

pyllyukko reviewed Apr 3, 2017

View reviewed changes

pyllyukko mentioned this pull request Apr 4, 2017

Improve the makefile #256

Open

7 tasks

nodiscc deleted the fixesfixesfixes branch April 26, 2017 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

README: refactor addons section; other fixes; fix GEOLOCATION/QUIET FOX sections of #208 #255

README: refactor addons section; other fixes; fix GEOLOCATION/QUIET FOX sections of #208 #255

nodiscc commented Mar 25, 2017 •

edited

Loading

nodiscc commented Mar 25, 2017 •

edited

Loading

Thorin-Oakenpants commented Mar 28, 2017

nodiscc commented Mar 28, 2017 •

edited

Loading

nodiscc commented Mar 28, 2017 •

edited

Loading

pyllyukko Mar 28, 2017

pyllyukko Mar 28, 2017

pyllyukko commented Mar 28, 2017

pyllyukko Apr 3, 2017

nodiscc Apr 3, 2017

pyllyukko Apr 3, 2017

pyllyukko Apr 3, 2017

nodiscc Apr 3, 2017

pyllyukko Apr 3, 2017

nodiscc Apr 3, 2017 •

edited

Loading

pyllyukko Apr 3, 2017

nodiscc Apr 3, 2017

pyllyukko Apr 3, 2017

pyllyukko commented Apr 3, 2017

nodiscc commented Apr 3, 2017 •

edited

Loading

pyllyukko Apr 3, 2017 •

edited

Loading

nodiscc Apr 4, 2017 •

edited by pyllyukko

Loading

pyllyukko Apr 4, 2017

nodiscc Apr 4, 2017 •

edited

Loading

pyllyukko Apr 4, 2017

README: refactor addons section; other fixes; fix GEOLOCATION/QUIET FOX sections of #208 #255

README: refactor addons section; other fixes; fix GEOLOCATION/QUIET FOX sections of #208 #255

Conversation

nodiscc commented Mar 25, 2017 • edited Loading

nodiscc commented Mar 25, 2017 • edited Loading

Thorin-Oakenpants commented Mar 28, 2017

nodiscc commented Mar 28, 2017 • edited Loading

nodiscc commented Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pyllyukko commented Mar 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nodiscc Apr 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pyllyukko commented Apr 3, 2017

nodiscc commented Apr 3, 2017 • edited Loading

pyllyukko Apr 3, 2017 • edited Loading

Choose a reason for hiding this comment

nodiscc Apr 4, 2017 • edited by pyllyukko Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nodiscc Apr 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nodiscc commented Mar 25, 2017 •

edited

Loading

nodiscc commented Mar 25, 2017 •

edited

Loading

nodiscc commented Mar 28, 2017 •

edited

Loading

nodiscc commented Mar 28, 2017 •

edited

Loading

nodiscc Apr 3, 2017 •

edited

Loading

nodiscc commented Apr 3, 2017 •

edited

Loading

pyllyukko Apr 3, 2017 •

edited

Loading

nodiscc Apr 4, 2017 •

edited by pyllyukko

Loading

nodiscc Apr 4, 2017 •

edited

Loading