Added custom user model with customer user manager #6
Conversation
This overwrites default django behaviour and allows to create users based on email instead of username
|
@bartczak-pa please see tests results. Those failed. |
This overwrites default django behaviour and allows to create users based on email instead of username
This overwrites default django behaviour and allows to create users based on email instead of username
|
@jacoor Migrations are fixed and code is passing tests now. |
There was a problem hiding this comment.
The code looks good.
However, Ruff is configured on purpose to enforce typings.
Please, do fix ruff errors and avoid #noqa unless really necessary.
I pushed an example of type updates for you, please fix other missing types.
If you have issues with typing, you can try to use AI to fix
- copilot - ask it to add typings for you (this works)
- or copy the code to Chat GPT and ask to add types.
Of course, do not forget to useruff check --fixfor other issues.
Again, only use #noqa if this is really necessary, like:
users/models.py:29:19: TRY003 Avoid specifying long messages outside the exception class, however, for this one google has very good answer you can find after couple seconds search:
https://docs.astral.sh/ruff/rules/raise-vanilla-args/
(I put "how to fix TRY003 Avoid specifying long messages outside the exception class`" as a question to google).
This overwrites default django behaviour and allows to create users based on email instead of username
|
@bartczak-pa you need to resolve conflicts. After that, tests will start to run and we will know if the code good. |
|
Great work. Now merge away! |
|
Typings and conflicts are resolved. |
This overwrites default django behaviour and allows to create users based on email instead of username.
Can we check if this code is okay?