Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test for base html #8

Merged
merged 11 commits into from
May 15, 2024
Merged

Create test for base html #8

merged 11 commits into from
May 15, 2024

Conversation

Pawelooo
Copy link
Contributor

No description provided.

@Pawelooo Pawelooo requested a review from a team May 12, 2024 15:04
@jacoor
Copy link
Contributor

jacoor commented May 14, 2024

@Pawelooo where are we with this?

@Pawelooo
Copy link
Contributor Author

Pawelooo commented May 14, 2024

@Pawelooo where are we with this?

@jacoor I don't know how to write these tests so that they pass

@jacoor
Copy link
Contributor

jacoor commented May 14, 2024

Ok. So why did you not ask on Discord? That's why we are a team.

articles/tests/test_base_page.py Show resolved Hide resolved
articles/tests/test_base_page.py Outdated Show resolved Hide resolved
articles/tests/test_base_page.py Outdated Show resolved Hide resolved
@jacoor
Copy link
Contributor

jacoor commented May 14, 2024

Found it.
please add "pytest-django" package to the project and remove articles/tests.py file.

@Pawelooo
Copy link
Contributor Author

image
I pass these tests

@jacoor
Copy link
Contributor

jacoor commented May 14, 2024

And? Are you asking for something or stating something?
The tests here are not passing and this is the source of truth.
Have you checked the failing tests here? There is clear into what is wrong.

@Pawelooo Pawelooo merged commit 494c9c9 into dev May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants