Fix/8694r3yfv community enhancement with privacy

[memorisanka]

https://app.clickup.com/t/8695gbbqh
https://app.clickup.com/t/8695gbc7n
https://app.clickup.com/t/8695gbgxm

Hi everyone!
I have added some bug fixes. Could you check it? :)

Summary by Sourcery

Implement a custom 403 permission denied view and enhance community privacy features by displaying access restrictions. Add validation and messaging for moderator management, and introduce a user-friendly 403 error page. Include tests to ensure correct handling of non-existing moderator removal.

New Features:

• Introduce a custom 403 permission denied view to handle unauthorized access attempts.

Bug Fixes:

• Fix the issue where users could attempt to remove non-existing moderators by adding validation and error messaging.

Enhancements:

• Enhance the CommunityListView to display a lock icon for private communities that the user cannot access.
• Add success messages for adding and removing moderators, and for successful community updates.

Documentation:

• Add a new 403.html template to provide a user-friendly error page for forbidden access.

Tests:

• Add a test case to verify the behavior when attempting to remove a non-existing moderator.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request implements several enhancements to the community feature, focusing on privacy improvements and user experience. The changes include adding a custom 403 error page, improving community list view to show private communities, enhancing moderator management, and adding success messages for various actions.

File-Level Changes

Change	Details	Files
Implemented a custom 403 (Forbidden) error page	Created a new custom_permission_denied_view function Added a new 403.html template Configured the custom 403 handler in settings.py	core/views.py core/templates/core/403.html reddit/settings.py
Enhanced community list view to handle private communities	Added a has_access property to community objects in the context Updated the community-list.html template to show a lock icon for private communities	core/views.py core/templates/core/community-list.html
Improved moderator management in CommunityDetailView	Added success messages when adding or removing moderators Implemented a check to prevent removing non-existent moderators Added a new test case for removing non-existing moderators	core/views.py core/tests/test_views.py
Added success messages for community updates	Implemented a success message in CommunityUpdateView when a community is updated successfully	core/views.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @memorisanka - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 3 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (performance): Consider combining the moderator check with the remove_moderator operation.

The current implementation performs an additional database query to check if the user is a moderator before calling remove_moderator. Consider combining these operations to avoid unnecessary database queries, possibly by handling the case in the remove_moderator method itself.

            try:
                moderator = CommunityMember.objects.get(
                    community=self.object, user=user, role=CommunityMember.MODERATOR
                )
                self.object.remove_moderator(moderator)
            except CommunityMember.DoesNotExist:
                # Handle the case where the user is not a moderator
                pass

[memorisanka]

I have no clue why the custom 403 page is not working. Any ideas? :)

[jacoor]

@memorisanka so the tests fails and there is good reason for it. Please update the 403 page to something generic, like "you don't have access to this content" or something generic. And update the failing test with it.
Thank you!

[memorisanka]

The test is fixed :)