Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample() lacks track argument #271

Closed
fonnesbeck opened this issue May 20, 2013 · 3 comments
Closed

sample() lacks track argument #271

fonnesbeck opened this issue May 20, 2013 · 3 comments
Labels
enhancements

Comments

@fonnesbeck
Copy link
Member

sample should have a track argument to specify which nodes should be tracked by the trace, as psample does. In my experience, it is the rule rather than the exception to track some deterministic nodes in a given model.
@fonnesbeck
Copy link
Member Author

OK, nevermind. Remembered that we have trace instead of track with sample. Lets rename them to be consistent. Which do we prefer?

@jsalvatier
Copy link
Member

Yeah, they should definitely be named the same. I think we should go with trace.

fonnesbeck pushed a commit that referenced this issue May 21, 2013
Unified track and trace arguments to address #271
ccf73d0
@fonnesbeck
Copy link
Member Author

OK, I have done this in ccf73d0, which passes all tests on my machine. Keep in mind this means the trace argument can be polymorphic, accepting either a list of variables to track or a NpTrace (or MultiTrace) object to continue sampling with.

@lancechua lancechua mentioned this issue Apr 28, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fonnesbeck @jsalvatier