Fix sample_ppc to use all chains #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close #2633 Index to samples in all chains for sample_ppc and sample_ppc_w
twiecki
reviewed
Nov 21, 2017
| @@ -671,14 +674,15 @@ def sample_ppc(trace, samples=None, model=None, vars=None, size=None, | |||
|
|
|||
| np.random.seed(random_seed) | |||
|
|
|||
| indices = np.random.randint(0, len(trace), samples) | |||
| indices = np.random.randint(0, nchain*len_trace, samples) | |||
| chain_idx, point_idx = np.divmod(indices, len_trace) | |||
|
LGTM! |
|
FYI |
Merged
aloctavodia
pushed a commit
that referenced
this pull request
Dec 8, 2017
* sample_ppc bug fix My fix in #2725 to use all chains breaks the `sample_ppc([point]...)` and also the progress bar. These issue should be fix here now and also add test for sample_ppc from a list. * fixe sample_ppc_w, edited release note * Add docstring, remove space
jordan-melendez
pushed a commit
to jordan-melendez/pymc3
that referenced
this pull request
Feb 6, 2018
* Fix sample_ppc to use all chains close pymc-devs#2633 Index to samples in all chains for sample_ppc and sample_ppc_w * add release note
jordan-melendez
pushed a commit
to jordan-melendez/pymc3
that referenced
this pull request
Feb 6, 2018
* sample_ppc bug fix My fix in pymc-devs#2725 to use all chains breaks the `sample_ppc([point]...)` and also the progress bar. These issue should be fix here now and also add test for sample_ppc from a list. * fixe sample_ppc_w, edited release note * Add docstring, remove space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2633
Index to samples in all chains for sample_ppc and sample_ppc_w