-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterization docs fix for precision/standard deviations. #2789
Conversation
"tau only required if sd not specified." Previously was "tau only required if tau not specified."
pymc3/distributions/continuous.py
Outdated
x = pm.StudentT('x', nu=15, mu=0, sd=10) | ||
|
||
with pm.Model(): | ||
x = pm.StudentT('x', nu=15, mu=0, sd=1/23) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be lam
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
pymc3/distributions/continuous.py
Outdated
@@ -347,9 +355,17 @@ class HalfNormal(PositiveContinuous): | |||
Parameters | |||
---------- | |||
sd : float | |||
Standard deviation (sd > 0). | |||
Standard deviation (sd > 0) .(only required if tau is not specified) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move .
to the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
pymc3/distributions/continuous.py
Outdated
tau : float | ||
Precision (tau > 0). | ||
Precision (tau > 0). (only required if sd is not specified) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #2788