Fix Rice distribution and add new parametrization (#3286) #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
reviewed
Dec 5, 2018
pymc3/distributions/continuous.py
Outdated
| @@ -3547,7 +3576,7 @@ def random(self, point=None, size=None): | |||
| """ | |||
| nu, sd = draw_values([self.nu, self.sd], | |||
| point=point, size=size) | |||
| return generate_samples(stats.rice.rvs, b=nu, scale=sd, loc=0, | |||
| return generate_samples(stats.rice.rvs, b=nu/sd, scale=sd, loc=0, | |||
There was a problem hiding this comment.
Suggested change
| return generate_samples(stats.rice.rvs, b=nu/sd, scale=sd, loc=0, | |
| return generate_samples(stats.rice.rvs, b=nu / sd, scale=sd, loc=0, |
|
Thanks @nbud. Can you add this to the release-notes? |
|
@twiecki Done and rebased |
|
Great, can merge when tests pass. Thanks! |
|
Looks like Travis failed due to a network error! |
|
Restarted it! |
|
Oops, I guess you wanted the order the other way around, can your ebase this one instead? |
|
Oh OK then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3286
I redefined the parametrization: nu is now the noncentrality parameter, b is the shape parameter. Before, nu was inconsistently the noncentrality or the shape parameter.
An extra test was added.