Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 3354 #3355

Merged
merged 3 commits into from
Jan 25, 2019
Merged

Fix for 3354 #3355

merged 3 commits into from
Jan 25, 2019

Conversation

lucianopaz
Copy link
Contributor

Fix for #3354. The only change is that draw_values now checks whether to add ObservedRV and MultiObservedRV instances to the stack of named nodes that may have to be drawn from to get the future _draw_value calls right later on.

@twiecki twiecki merged commit 254c574 into pymc-devs:master Jan 25, 2019
@twiecki
Copy link
Member

twiecki commented Jan 25, 2019

Thanks! Can you give your PRs more descriptive names?

@lucianopaz
Copy link
Contributor Author

Oh sorry! Yes, I'll make more descriptive names from now on

@lucianopaz lucianopaz deleted the iss3354 branch February 24, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucianopaz @twiecki