Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated RELEASE-NOTES.md #3838

Merged
merged 2 commits into from
Mar 19, 2020
Merged

updated RELEASE-NOTES.md #3838

merged 2 commits into from
Mar 19, 2020

Conversation

Ahanmr
Copy link
Contributor

@Ahanmr Ahanmr commented Mar 19, 2020

Added the deprecation of sd with sigma in newer version with DeprecationWarning on usage of sd. (see #3688 and #3837 ).

Added the deprecation of `sd` with `sigma` in newer version with DeprecationWarning on usage of `sd`.
@Ahanmr
Copy link
Contributor Author

Ahanmr commented Mar 19, 2020

@twiecki I've added the change into the RELEASE-NOTES

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #3838 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3838      +/-   ##
==========================================
- Coverage   90.74%   90.72%   -0.02%     
==========================================
  Files         135      135              
  Lines       21130    21130              
==========================================
- Hits        19174    19170       -4     
- Misses       1956     1960       +4
Impacted Files Coverage Δ
pymc3/backends/report.py 90.62% <0%> (-2.35%) ⬇️
pymc3/step_methods/hmc/base_hmc.py 95.32% <0%> (-0.94%) ⬇️

RELEASE-NOTES.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Ahanmr Ahanmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes in RELEASE-NOTES.md with regard to deprecated sd with sigma by giving out a DeprecationWarning when initialisation of sd (#3688 and #3837)

@aloctavodia aloctavodia merged commit 363afc8 into pymc-devs:master Mar 19, 2020
@aloctavodia
Copy link
Member

thanks @Ahanmr

@Ahanmr
Copy link
Contributor Author

Ahanmr commented Mar 19, 2020

Thank you @aloctavodia for the opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants