Revert breaking size changes

[brandonwillard]

This PR reverts the size-related breaking changes and Model/Distribution design issues introduced by #4625.

Closes #4662.

[twiecki]

Thanks @brandonwillard, just to make sure, is this literally a 100% reversion to the pre-#4625 state or does it introduce any other changes?

[brandonwillard]

Thanks @brandonwillard, just to make sure, is this literally a 100% reversion to the pre-#4625 state or does it introduce any other changes?

Yes, and resolutions to conflicts caused by subsequent changes to code touched by #4625. I believe the latter was only relevant to the most recently merged PR #4684.

That's the main reason for doing this reversion ASAP: it will only get harder to revert, track, and/or repair the problems caused by #4625 if we keep merging things into v4.

[twiecki]

Let's wait with merging until I fixed the tests in #4696.

[michaelosthege]

@brandonwillard 👎

[brandonwillard]

@brandonwillard

I asked @twiecki right before merging this.

[twiecki]

Yes I said he should merge as it was holding up other stuff.

…

On Fri, May 14, 2021, 20:43 Brandon T. Willard ***@***.***> wrote: [image: image] <https://user-images.githubusercontent.com/5894642/118314110-f6775380-b4f3-11eb-818e-1406e01c7338.png> @brandonwillard <https://github.com/brandonwillard> I asked @twiecki <https://github.com/twiecki> right before merging this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4693 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFETGA2HDXAEUPUG63GMV3TNVVMXANCNFSM443HPFNA> .