Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement backwards-compatible shape and dims with Ellipsis support #4696

Merged
merged 9 commits into from
Jun 4, 2021
Merged

Implement backwards-compatible shape and dims with Ellipsis support #4696

merged 9 commits into from
Jun 4, 2021

Commits on Jun 4, 2021

  1. Disallow "__sample__" as a dimension name 

    Co-authored-by: Thomas Wiecki <[email protected]>
    @michaelosthege @twiecki
    michaelosthege and twiecki committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    c3e8210 View commit details
    Browse the repository at this point in the history

  2. Add OS-independent #4652 regression tests

    @michaelosthege
    michaelosthege committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    35bb41a View commit details
    Browse the repository at this point in the history

  3. Make change_rv_size more robust 

    Co-authored-by: Ricardo <[email protected]>
Co-authored-by: Thomas Wiecki <[email protected]>
    @michaelosthege @ricardoV94 @twiecki
    3 people committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    dbb1f20 View commit details
    Browse the repository at this point in the history

  4. Introduce ShapeWarning

    @michaelosthege
    michaelosthege committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    b9b0b23 View commit details
    Browse the repository at this point in the history

  5. Refactor test to use InferenceData

    @michaelosthege
    michaelosthege committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    124b33c View commit details
    Browse the repository at this point in the history

  6. Implement backwards-compatble shape and Ellipsis-enabled dims 

    Co-authored-by: Thomas Wiecki <[email protected]>
Co-authored-by: Ricardo <[email protected]>
    @michaelosthege @twiecki @ricardoV94
    3 people committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    c7d477c View commit details
    Browse the repository at this point in the history

  7. Add Ellipsis-support for the shape kwarg

    @michaelosthege
    michaelosthege committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    46c225e View commit details
    Browse the repository at this point in the history

  8. Separate shape logic into a separate file (#4708) 

    Co-authored-by: Michael Osthege <[email protected]>
    @twiecki @michaelosthege
    twiecki and michaelosthege committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    8bdc225 View commit details
    Browse the repository at this point in the history

  9. Use initial instead of testval internally 

    Co-authored-by: Oriol Abril-Pla <[email protected]>
    @michaelosthege @OriolAbril
    michaelosthege and OriolAbril authored Jun 4, 2021
    Configuration menu
    Copy the full SHA
    7e747f2 View commit details
    Browse the repository at this point in the history