Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase of 4667 #4699

Closed
wants to merge 3 commits into from
Closed

Rebase of 4667 #4699

wants to merge 3 commits into from

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented May 14, 2021 •
edited
Loading

Rebase of #4667 onto v4.

@twiecki twiecki changed the base branch from master to v4 May 14, 2021 10:26
michaelosthege and others added 3 commits May 14, 2021 12:27
@michaelosthege @twiecki
Check ndim of new_size kwarg in change_rv_size
8c1c0ff 
And don't use np.atleast_1d on things that can be tensors.
@michaelosthege @twiecki
Condition issue #4652 xfail on platform
47fd9b8
@michaelosthege @twiecki
Revert functionality change of size kwarg
f326166 
Corresponding tests were reverted, or edited to use other parametrization flavors.
The Ellipsis feature now works with all three dimensionality kwargs.
The MultinomialRV implementation was removed, because the broadcasting behavior was implemented in Aesara.
Closes #4662
@twiecki twiecki changed the title Fix 4662 Rebase of 4662 May 14, 2021
@twiecki twiecki changed the title Rebase of 4662 Rebase of 4667 May 14, 2021
@twiecki twiecki closed this May 14, 2021
@michaelosthege michaelosthege deleted the fix-4662 branch October 11, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twiecki @michaelosthege