Fix deprecation warning for save/load_trace #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5106 +/- ##
==========================================
- Coverage 77.83% 77.81% -0.03%
==========================================
Files 87 87
Lines 14006 14008 +2
==========================================
- Hits 10902 10900 -2
- Misses 3104 3108 +4
|
canyon289
approved these changes
Oct 28, 2021
|
How long has this been there? Isn't it time we just remove them? |
|
Not sure, but highly likely that users have not seen the message. |
|
Seems like it was added 2 years ago: #3902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FutureWarningsare intended for users andDeprecationWarningsfor developers. I am not sure but I think by default jupyter notebook will show the former but not the later. Just in case I added an additional message in case a user attempts to usesave_tracefor saving InferenceData.