Cleanup logprob module #7443
Merged
Cleanup logprob module #7443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now properly done by PartiallyObservedRV
Also: * Introduce MeasurableOpMixin for string representation * Subclass directly instead of registering manually
ricardoV94
force-pushed
the
cleanup_logprob_module
branch
from
27e5525
to
78f148f
Compare
ricardoV94
commented
Aug 1, 2024
|
|
||
| class MeasurableElemwise(Elemwise): | ||
| def __str__(self): | ||
| return f"Measurable{super().__str__()}" |
There was a problem hiding this comment.
This allows seeing when a Measurable replacement was actually performed in the IR graph. Most times we use a subclass of the pre-existing Op, and it would not be distinguishable in the string representation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7443 +/- ##
==========================================
- Coverage 92.18% 92.15% -0.04%
==========================================
Files 103 103
Lines 17263 17227 -36
==========================================
- Hits 15914 15875 -39
- Misses 1349 1352 +3
|
twiecki
approved these changes
Aug 5, 2024
We removed a hacky functionality that is properly implemented by the auto-imputation machinery |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some non-functional cleanup of the logprob module that spinoff from other PRs
📚 Documentation preview 📚: https://pymc--7443.org.readthedocs.build/en/7443/