Use old ld64 linker on MacOS >= 15.0 #1083
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Nov 11, 2024
pytensor/link/c/cmodule.py
Outdated
| # XCode15 introduced ld_prime linker. At the time of writing, this linker | ||
| # leads to multiple issues, so we supply a flag to use the older dynamic | ||
| # linker: ld64 | ||
| cxxflags.append("-ld64") |
There was a problem hiding this comment.
I’ll have to add a platform version check to add this flag or not
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 82.10% 82.10% -0.01%
==========================================
Files 183 183
Lines 47930 47932 +2
Branches 8633 8634 +1
==========================================
+ Hits 39354 39355 +1
Misses 6410 6410
- Partials 2166 2167 +1
|
|
@ricardoV94, I patched this |
ricardoV94
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a flag to use Mac's older
ld64linker instead of the newld_primelinker. This might be the underlying cause of the problems that are still coming out of #1005. These issues show thatpytensorfails in its compilation phase. The exception is a bit masked, but it seems to indicate that the linker had problems and exited with a signal. In my case it was a segfault with signal 11. I've seen other cases that seem similar and complain about symbols that should be defined in libtapi.dylib. The problem is that I can't reproduce in this isolated environment. My attempt to check whether this problem exists on Mac was to bump the version of the macos runner to 15 (the bump was supposed to happen during december anyway).Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1083.org.readthedocs.build/en/1083/