Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setuptools version to >=59 #812

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jun 9, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@maresb maresb requested a review from ferrine June 9, 2024 14:14
@maresb
Copy link
Contributor Author

maresb commented Jun 9, 2024

@ferrine, I have a vague recollection that you might have some particular setuptools requirements. Will this break anything for you?

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (1935809) to head (fcaa2e9).
Report is 169 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   80.83%   80.84%           
=======================================
  Files         163      163           
  Lines       46897    46890    -7     
  Branches    11468    11468           
=======================================
- Hits        37910    37909    -1     
+ Misses       6774     6768    -6     
  Partials     2213     2213           
Files with missing lines Coverage Δ
pytensor/link/c/exceptions.py 80.00% <100.00%> (+38.33%) ⬆️

@ferrine
Copy link
Member

ferrine commented Jun 10, 2024

@ferrine, I have a vague recollection that you might have some particular setuptools requirements. Will this break anything for you?

I remember, there was an issue with some deprecated functionality that is no longer relevant for the context. The particular issue was that ancient setuptools were provided by the cloud provider, causing installation problems.

@maresb maresb requested a review from ricardoV94 June 10, 2024 10:28
@ricardoV94 ricardoV94 merged commit ee0075b into pymc-devs:main Jun 10, 2024
56 checks passed
@maresb maresb deleted the bump-setuptools branch June 10, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants