Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing milksnake with maturin #187

Closed
dvzrv opened this issue Jan 28, 2022 · 4 comments · Fixed by #195
Closed

Consider replacing milksnake with maturin #187

dvzrv opened this issue Jan 28, 2022 · 4 comments · Fixed by #195

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Jan 28, 2022

Hi! It looks like maturin is the more actively maintained project, whereas milksnake appears rather dead (no release in four years, open pull requests are ignored).

Would it be possible for this project to facilitate maturin instead of milksnake (unless I'm misinterpreting the scope).

I'm asking this because I'm packaging maturin on Arch Linux already and packaging a rather undead package for building cmsis-pack-manager could potentially be circumvented.

@mathias-arm
Copy link
Collaborator

We have been considering it. When we moved to GitHub Actions and added support for universal2 binaries on Mac, I tried using maturin but did not succeed. CFFI is what we use and that seems to be maturin's third priority (with PyO3 and rust-cpython ahead of CFFI) and there was not that many examples at the time. I am sure things have evolved since then.

If you (or someone else) can try to get maturin working with cmsis-pack-manager and cibuidwheel I would certainly give it another shot.

@dvzrv
Copy link
Contributor Author

dvzrv commented Jan 28, 2022

@mathias-arm Thanks for getting back on this inquiry!

I'm afraid I lack the expertise (and time) to drive such a change for this project though. But maybe someone else has? :)

@dvzrv
Copy link
Contributor Author

dvzrv commented Feb 8, 2022

FWIW, due to milksnake seemingly being abandonware it will stop working (as in, downstreams will not be able to package it without a lot of pain and will be more likely to remove it if that is the case) in the not too distant future, as it is not yet PEP517 ready (somewhat related PR to improve the setuptools integration: getsentry/milksnake#30)

@mbrossard
Copy link
Collaborator

Could you try to build the maturin branch? I am not sure I have properly connected all the pieces. I need to update GitHub Actions configuration, and setuptools_scm needs to be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants