Replace Milksnake by Maturin #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Python 3.11 and removing Python 3.6 Use Rust 1.63.0 to maximize Linux compatibility Remove setuptools_scm Update cibuildwheel action
mbrossard
force-pushed
the
maturin
branch
9 times, most recently
from
086bd98
to
70b695d
Compare
4 tasks
flit
approved these changes
Dec 17, 2022
dvzrv
reviewed
Dec 17, 2022
| "setuptools_scm[toml]>=3.4", | ||
| "wheel", | ||
| "milksnake>=0.1.2" | ||
| "maturin>=0.13,<0.14", |
There was a problem hiding this comment.
Um, is there any reason to limit the versions here?
Upstream maturin is already at 0.14.6 and that is also what we package on Arch Linux.
There was a problem hiding this comment.
I originally had some issue with maturin 0.14 (it might have been that it requires Rust 2021 Edition), but once things were working I should have circled back and tried again.
luizirber
added a commit
to sourmash-bio/sourmash
that referenced
this pull request
Dec 28, 2022
While investigating why the [Python 3.11] PR failed in conda-forge I found out that there is an error in [milksnake]. Main issue is that milksnake seems to be abandoned, without recent releases, so submitting a PR to fix there might be unfruitful. [Python 3.11]: conda-forge/sourmash-minimal-feedstock#36 [milksnake]: https://github.com/getsentry/milksnake [maturin] is a PEP517-compatible backend for building packages and aimed at Rust packages (pure or mixed with more Python code, like sourmash). It is actively maintained, and supports the `cffi` bindings case that we use too. [maturin]: https://maturin.rs This PR is based on pyocd/cmsis-pack-manager#195 Closes #1564 (previous try with `setuptools-rust`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manylinuxversion used), this should fix building wheels in CI.cibuildwheel. Sincecmsis-pack-managerdoes not use Python API, the bindings works independently of the version of Python. This is detected bycibuildwheelsince version 2.8.0. Upgrading the version of This will reduce the number of binaries.It possibly fixes the issues #110 and #176 (needs to be confirmed).