Skip to content

Commit

Permalink
Remove shared_library key (#18)
Browse files Browse the repository at this point in the history
This key is removed in

- pyodide: pyodide/pyodide#4996
- pyodide-lock: pyodide/pyodide-lock#31

and this is the last PR to remove it in pyodide-build as well.
  • Loading branch information
ryanking13 authored Aug 14, 2024
1 parent f50e7db commit fca5d09
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

## [0.28.0] - 2024/08/14

- `pyodide xbuildenv` subcommand is now publicly available.
[#15](https://github.com/pyodide/pyodide-build/pull/15)

Expand Down
6 changes: 1 addition & 5 deletions pyodide_build/buildall.py
Original file line number Diff line number Diff line change
Expand Up @@ -731,11 +731,7 @@ def generate_packagedata(

pkg_type = pkg.package_type
if pkg_type == "shared_library":
# We handle cpython modules as shared libraries
pkg_entry.shared_library = True
pkg_entry.install_dir = (
"stdlib" if pkg_type == "cpython_module" else "dynlib"
)
pkg_entry.install_dir = "dynlib"

pkg_entry.depends = [x.lower() for x in pkg.run_dependencies]

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ requires-python = ">=3.12"
dependencies = [
"build~=1.2.0",
"pyodide-cli~=0.2.1",
"pyodide-lock==0.1.0a6",
"pyodide-lock==0.1.0a7",
"auditwheel-emscripten~=0.0.9",
"pydantic>=2,<3",
"cmake>=3.24",
Expand Down

0 comments on commit fca5d09

Please sign in to comment.