Don't assume test.pyodide_test always exists. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPython has a custm doctest runner and having pytest-pyodide installed make the test suite fails on this attribute.
|
Yes, I maybe should not have a single env will all the projects I develop, but it helps find issues... |
|
I'm going to merge despite the test failures since the patch looks unproblematic. @ryanking13 is CI failing on main? |
Yeah, it seems like the latest Chrome has some issues with pytest-pyodide. micropip CI is also experiencing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython has a custom doctest runner and having pytest-pyodide installed make the test suite fails on this attribute.