Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pytest extra args option #59

Merged
merged 4 commits into from
Dec 14, 2022
Merged

add pytest extra args option #59

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6039ddf
add pytest extra args option
joemarshall Nov 2, 2022
cd8afca
Update .github/workflows/main.yaml
joemarshall Nov 3, 2022
d1e67b1
Merge branch 'pyodide:main' into pytest-extra-args
joemarshall Nov 24, 2022
3c8bc6f
Merge branch 'main' into pytest-extra-args
ryanking13 Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ on:
required: false
type: string
default: "ubuntu-latest"
pytest-extra-args:
required: false
type: string
default: ""
driver-version:
required: false
type: string
Expand Down Expand Up @@ -165,7 +169,8 @@ jobs:
--cov=pytest_pyodide \
--dist-dir=./pyodide-dist/ \
--runner=${{ inputs.runner }} \
--rt ${{ inputs.browser }}
--rt ${{ inputs.browser }} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--rt ${{ inputs.browser }} \
--rt=${{ inputs.browser }} \

Without this, pytest-extra-args will be push to runtime list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay this change breaks one test, which passes multiple browsers to inputs.browser. I think I added that to test whether --rt correctly handles multiple parameters. But I think we can remove that test from filtermatrix.py, regarding that users who use this action don't need that test.

${{ inputs.pytest-extra-args }}

- uses: codecov/codecov-action@v3
if: ${{ inputs.self-build==1 && (github.event.repo.name == 'pyodide/pytest-pyodide' || github.event_name == 'pull_request') }}
Expand Down