Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume for docker socket path #144

Merged
merged 3 commits into from
Jan 24, 2019
Merged

Add volume for docker socket path #144

merged 3 commits into from
Jan 24, 2019

Conversation

mauvehed
Copy link
Contributor

The current docker-compose.yml file will throw errors in an endless start/stop sequence because it's missing the bind mount for the docker socket. I'm assuming this isn't intentional as the documentation doesn't state that this should be added by the user.

dirtycajunrice and others added 3 commits January 16, 2019 20:23
v0.6.0 Merge
v1.0.0 Merge
The current docker-compose.yml file will throw errors in an endless start/stop sequence because it's missing the bind mount for the docker socket. I'm assuming this isn't intentional as the documentation doesn't state that this should be added by the user.
@dirtycajunrice
Copy link
Member

you need to change the pull request to develop. but you are right!

@docwhat
Copy link

docwhat commented Jan 24, 2019

@dirtycajunrice Owners and Contributors can change the base for a change request by clicking "EDIT" next to the issue's subject.

@mauvehed mauvehed changed the base branch from master to develop January 24, 2019 14:21
@mauvehed
Copy link
Contributor Author

Updated from master to develop.

@circa10a circa10a merged commit fa6b1f4 into pyouroboros:develop Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants