Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI expose fewer globals, formatting #31

Merged
merged 12 commits into from
Oct 25, 2018
Merged

Make CLI expose fewer globals, formatting #31

merged 12 commits into from
Oct 25, 2018

Conversation

tlkamp
Copy link
Contributor

@tlkamp tlkamp commented Oct 24, 2018

Refactors a bit of the code (cli.py uses fewer globals, and other code no longer relies on those globals).

I ran autopep8 against the files I worked in, please forgive me for the whitespace diffs

@codecov-io
Copy link

codecov-io commented Oct 24, 2018

Codecov Report

Merging #31 into master will increase coverage by 2.39%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   94.07%   96.47%   +2.39%     
==========================================
  Files           7        7              
  Lines         152      142      -10     
==========================================
- Hits          143      137       -6     
+ Misses          9        5       -4
Impacted Files Coverage Δ
ouroboros/cli.py 100% <100%> (ø) ⬆️
ouroboros/__init__.py 100% <100%> (ø) ⬆️
ouroboros/main.py 90.24% <100%> (ø) ⬆️
ouroboros/container.py 97.43% <90%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b36a8...e51edbe. Read the comment docs.

@tlkamp
Copy link
Contributor Author

tlkamp commented Oct 25, 2018

Will add more tests.

@circa10a
Copy link
Member

Will add more tests.

alt text

@tlkamp
Copy link
Contributor Author

tlkamp commented Oct 25, 2018

@circa10a finally yeesh

@circa10a
Copy link
Member

circa10a commented Oct 25, 2018

@tlkamp since this is from add-script-file, ready to merge?

@circa10a
Copy link
Member

If so, bump the version in __init__.py and it can be deployed.

@tlkamp
Copy link
Contributor Author

tlkamp commented Oct 25, 2018

Yeah, ignore my shitty branch names

@circa10a circa10a merged commit b1a0dd9 into pyouroboros:master Oct 25, 2018
@tlkamp tlkamp deleted the add-script-file branch October 27, 2018 13:49
@dirtycajunrice dirtycajunrice added the enhancement New feature or request label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants