fix internal dependencies of libraries #101
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug when two folders of dependencies have the same soname:
`pp external_refs_by_fn
{'libxml2mod.so': {'linux_x86_64': {'libs': {'libc.so.6': '/lib64/libc-2.5.so',
'libdl.so.2': '/lib64/libdl-2.5.so',
'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libm.so.6': '/lib64/libm-2.5.so',
'libpthread.so.0': '/lib64/libpthread-2.5.so',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 0},
'manylinux1_x86_64': {'libs': {'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 100}},
'libxsltmod.so': {'linux_x86_64': {'libs': {'libc.so.6': '/lib64/libc-2.5.so',
'libdl.so.2': '/lib64/libdl-2.5.so',
'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libm.so.6': '/lib64/libm-2.5.so',
'libpthread.so.0': '/lib64/libpthread-2.5.so',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 0},
'manylinux1_x86_64': {'libs': {'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 100}}}
`
and we endup with a soname_map that looks like this:
(Pdb) pp soname_map
{'libexslt.so.0': ('libexslt-bdf34a56.so.0.8.7',
'.libslibxsltmod/libexslt-bdf34a56.so.0.8.7'),
'libxml2.so.2': ('libxml2-e6a3f6dc.so.2.6.21',
'.libslibxsltmod/libxml2-e6a3f6dc.so.2.6.21'),
'libxslt.so.1': ('libxslt-88a6ba3e.so.1.1.9',
'.libslibxsltmod/libxslt-88a6ba3e.so.1.1.9'),
'libz.so.1': ('libz-a147dcb0.so.1.2.3',
'.libslibxsltmod/libz-a147dcb0.so.1.2.3')}
All the SOs in the
.libslibxml2mod
don't get updated.