Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix internal dependencies of libraries #101

Closed
wants to merge 1 commit into from
Closed

Conversation

louhibi
Copy link

@louhibi louhibi commented Sep 26, 2018

Found a bug when two folders of dependencies have the same soname:
`pp external_refs_by_fn

{'libxml2mod.so': {'linux_x86_64': {'libs': {'libc.so.6': '/lib64/libc-2.5.so',
'libdl.so.2': '/lib64/libdl-2.5.so',
'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libm.so.6': '/lib64/libm-2.5.so',
'libpthread.so.0': '/lib64/libpthread-2.5.so',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 0},
'manylinux1_x86_64': {'libs': {'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 100}},
'libxsltmod.so': {'linux_x86_64': {'libs': {'libc.so.6': '/lib64/libc-2.5.so',
'libdl.so.2': '/lib64/libdl-2.5.so',
'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libm.so.6': '/lib64/libm-2.5.so',
'libpthread.so.0': '/lib64/libpthread-2.5.so',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 0},
'manylinux1_x86_64': {'libs': {'libexslt.so.0': '/usr/local/lib/libexslt.so.0.8.7',
'libxml2.so.2': '/usr/local/lib/libxml2.so.2.6.21',
'libxslt.so.1': '/usr/local/lib/libxslt.so.1.1.9',
'libz.so.1': '/lib64/libz.so.1.2.3'},
'priority': 100}}}
`

and we endup with a soname_map that looks like this:

(Pdb) pp soname_map
{'libexslt.so.0': ('libexslt-bdf34a56.so.0.8.7',
'.libslibxsltmod/libexslt-bdf34a56.so.0.8.7'),
'libxml2.so.2': ('libxml2-e6a3f6dc.so.2.6.21',
'.libslibxsltmod/libxml2-e6a3f6dc.so.2.6.21'),
'libxslt.so.1': ('libxslt-88a6ba3e.so.1.1.9',
'.libslibxsltmod/libxslt-88a6ba3e.so.1.1.9'),
'libz.so.1': ('libz-a147dcb0.so.1.2.3',
'.libslibxsltmod/libz-a147dcb0.so.1.2.3')}

All the SOs in the .libslibxml2mod don't get updated.

Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test to show the bug being fixed?

@louhibi
Copy link
Author

louhibi commented Sep 26, 2018

@lpsinger will your PR #90 fix this bug ?

@louhibi
Copy link
Author

louhibi commented Sep 26, 2018

@ehashman I will try to add a test if #90 will not fix this one too.

@lpsinger
Copy link
Contributor

@lpsinger will your PR #90 fix this bug ?

Yes, it should.

@ehashman
Copy link
Member

I will close this in favour of #90 (which I think is a more direct solution) and adding a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants