Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manylinux2014 policy #192

Merged
merged 2 commits into from
Oct 11, 2019
Merged

manylinux2014 policy #192

merged 2 commits into from
Oct 11, 2019

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Sep 22, 2019

Add support for manylinux2014 policy
Symbol versions were updated using latest centos:7 docker image by running the updated scripts/calculate_symbol_versions.py

c.f. #185
c.f. pypa/manylinux#338

tests in #193 (I'd rather keep them separated while waiting for official pip and manylinux image)

@codecov

This comment has been minimized.

@mayeut mayeut changed the title WIP - manylinux2014 policy manylinux2014 policy Sep 25, 2019
@mayeut mayeut requested a review from lkollar September 28, 2019 16:07
@mayeut
Copy link
Member Author

mayeut commented Sep 28, 2019

@lkollar,

since you reviewed #141, can you please also review this one to get things going for manylinux2014

Thanks

Copy link
Contributor

@lkollar lkollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few questions.

auditwheel/policy/policy.json Show resolved Hide resolved
auditwheel/policy/policy.json Outdated Show resolved Hide resolved
@di
Copy link
Member

di commented Oct 11, 2019

python/peps#1201 has been merged, is there anything left to do here?

@takluyver takluyver merged commit 8b255b5 into pypa:master Oct 11, 2019
@mayeut mayeut deleted the manylinux2014 branch October 12, 2019 09:33
This was referenced Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants