-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manylinux2014 policy #192
Merged
Merged
manylinux2014 policy #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
25 tasks
mayeut
force-pushed
the
manylinux2014
branch
from
September 28, 2019 16:04
d135204
to
61edd31
Compare
auvipy
approved these changes
Sep 28, 2019
lkollar
reviewed
Sep 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few questions.
di
reviewed
Sep 29, 2019
auvipy
approved these changes
Oct 4, 2019
…bol versions are not version strings
python/peps#1201 has been merged, is there anything left to do here? |
takluyver
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for manylinux2014 policy
Symbol versions were updated using latest centos:7 docker image by running the updated
scripts/calculate_symbol_versions.py
c.f. #185
c.f. pypa/manylinux#338
tests in #193 (I'd rather keep them separated while waiting for official pip and manylinux image)