Fixing empty verbosity flag argument to subprocess.check_call

pypa · Apr 8, 2018 · 8d9d970 · 8d9d970
1 parent c563bca
commit 8d9d970
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cibuildwheel/macos.py b/cibuildwheel/macos.py
@@ -87,7 +87,8 @@ def call(args, env=None, cwd=None, shell=False):
             call(before_build_prepared, env=env, shell=True)
 
         # build the wheel
-        call([pip, 'wheel', abs_project_dir, '-w', '/tmp/built_wheel', '--no-deps', get_build_verbosity_flag(build_verbosity)], env=env)
+        build_verbosity_flag = get_build_verbosity_flag(build_verbosity)
+        call([pip, 'wheel', abs_project_dir, '-w', '/tmp/built_wheel', '--no-deps'] + ([build_verbosity_flag] if build_verbosity_flag else []), env=env)
         built_wheel = glob('/tmp/built_wheel/*.whl')[0]
 
         if built_wheel.endswith('none-any.whl'):

diff --git a/cibuildwheel/windows.py b/cibuildwheel/windows.py
@@ -82,7 +82,8 @@ def shell(args, env=None, cwd=None):
             shell([before_build_prepared], env=env)
 
         # build the wheel
-        shell(['pip', 'wheel', abs_project_dir, '-w', built_wheel_dir, '--no-deps', get_build_verbosity_flag(build_verbosity)], env=env)
+        build_verbosity_flag = get_build_verbosity_flag(build_verbosity)
+        shell(['pip', 'wheel', abs_project_dir, '-w', built_wheel_dir, '--no-deps'] + ([build_verbosity_flag] if build_verbosity_flag else []), env=env)
         built_wheel = glob(built_wheel_dir+'/*.whl')[0]
 
         # install the wheel