-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitLab support #1295
Update GitLab support #1295
Conversation
Ah, Gitlab supports windows now? Could you add a job to our It might also be good to run an emulation test on Gitlab, we already have a test like that configured on GHA, that could be replicated there. Not essential though, it would depend on how much CI time it eats up I reckon. |
|
Been a while since we tested the minimals, lets see if there are any gremlins lurking...
edit: there are some other gremlins. I'll address these in a separate PR. |
Done, not 100% sure if it'll work properly though. I'm also waiting to hear back on GitLab for access to macOS runner to find out if my example can build wheels for macOS. Not sure how long that will take so feel free to merge this in and I'll create another MR when I get that working. |
Thanks @wbarnha! |
Closes #1294