-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about new delocate error "Library dependencies do not satisfy target MacOS" #1766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this @Czaki ! A big improvement for sure.
Co-authored-by: Joe Rickerby <[email protected]>
I set this to draft to make it less tempting to merge before delocate is ready. :) |
CC #1796. |
Can it also detect of the arch is wrong? Missing Apple Silicon parts on a universal or arm wheel? |
Not in the current state. When creating PR, I assume that some of the inner binary could be single arch only. But will raise an error if there is no binary with a given arch here: https://github.com/matthew-brett/delocate/blob/526cc494e4c5750380a6d6ad3d31a2040ff63c60/delocate/delocating.py#L798 It is possible to extend the check to validate archs, but will require to use a dependency graph in place of simple scan files. As delocate has been released 2 days ago, I mark it as ready for review. |
After 3 years, I finally contributed to delocate with PR is adding validation of platform tag against real requirements.
As many users open issues in this repository even when should in some other package, I think is worth to at least opening PR for better visibility.
This PR should not be merged before the next delocate release.