-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more reliably validate Podman API version #2016
fix: more reliably validate Podman API version #2016
Commits on Sep 18, 2024
-
fix: parse version strings that include dashes
It's possible for some container engines to report their versions with a dash (e.g., "4.9.4-rhel"), which breaks packaging.version.Version's ability to parse the string. This commit introduces a version_from_string method which santizies the version string and returns an instance of Version.
Configuration menu - View commit details
-
Copy full SHA for a1b4026 - Browse repository at this point
Copy the full SHA a1b4026View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 8f9b3ee - Browse repository at this point
Copy the full SHA 8f9b3eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e57910 - Browse repository at this point
Copy the full SHA 8e57910View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb0b2f0 - Browse repository at this point
Copy the full SHA eb0b2f0View commit details -
fix: properly define _version_from_string method
Also, lift the method up and prefix with a "_" to better match the existing conventions
Configuration menu - View commit details
-
Copy full SHA for 060d96c - Browse repository at this point
Copy the full SHA 060d96cView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for a6ae1c4 - Browse repository at this point
Copy the full SHA a6ae1c4View commit details
Commits on Sep 19, 2024
-
refactor: more robust podman ver check
Use the "podman --version" command instead of "podman version -f {{json .}}" for better reliability across distributions.
Configuration menu - View commit details
-
Copy full SHA for f19deee - Browse repository at this point
Copy the full SHA f19deeeView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 4ccfcaf - Browse repository at this point
Copy the full SHA 4ccfcafView commit details
Commits on Sep 21, 2024
-
Lower Docker API check to 1.41 Podman versions are not PEP440 compliant, remove distro specific suffixes before parsing. Add tests with real-world outputs and some made up ones.
Configuration menu - View commit details
-
Copy full SHA for 3c8daff - Browse repository at this point
Copy the full SHA 3c8daffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b73c0e - Browse repository at this point
Copy the full SHA 4b73c0eView commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bbfb496 - Browse repository at this point
Copy the full SHA bbfb496View commit details