Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more reliably validate Podman API version #2016

Merged
merged 11 commits into from
Oct 1, 2024

Commits on Sep 18, 2024

  1. fix: parse version strings that include dashes

    It's possible for some container engines to report their versions with a dash (e.g., "4.9.4-rhel"), which breaks packaging.version.Version's ability to parse the string. This commit introduces a version_from_string method which santizies the version string and returns an instance of Version.
    zachlewis authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a1b4026 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f9b3ee View commit details
    Browse the repository at this point in the history
  3. cleanup: pacify ruff

    zachlewis committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8e57910 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eb0b2f0 View commit details
    Browse the repository at this point in the history
  5. fix: properly define _version_from_string method

    Also, lift the method up and prefix with a "_" to better match the existing conventions
    zachlewis committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    060d96c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a6ae1c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. refactor: more robust podman ver check

    Use the "podman --version" command instead of "podman version -f {{json .}}" for better reliability across distributions.
    zachlewis authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f19deee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ccfcaf View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. fix: oci engine version check

    Lower Docker API check to 1.41
    Podman versions are not PEP440 compliant, remove distro specific suffixes before parsing.
    Add tests with real-world outputs and some made up ones.
    mayeut committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    3c8daff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b73c0e View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Add FlexibleVersion

    per review comment
    mayeut committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    bbfb496 View commit details
    Browse the repository at this point in the history