Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Scientific Python repo-review suggestions #240

Closed
DimitriPapadopoulos opened this issue Mar 10, 2024 · 0 comments · Fixed by #277
Closed

Apply Scientific Python repo-review suggestions #240

DimitriPapadopoulos opened this issue Mar 10, 2024 · 0 comments · Fixed by #277

Comments

@DimitriPapadopoulos
Copy link
Contributor

Apply those rules that make sense:
https://learn.scientific-python.org/development/guides/repo-review/?repo=pypa%2Fdistutils&branch=main

Most if not all of these rules already appear in jaraco/skeleton#112. In the issue, I am interested in prerequisites to applying these rules, such as fixing linter issues:

RF101: Bugbear must be selected
Must select the flake8-bugbear B checks. Recommended:

[tool.ruff.lint]
extend-select = [
  "B",  # flake8-bugbear
]

RF102: isort must be selected
Must select the isort I checks. Recommended:

[tool.ruff.lint]
extend-select = [
  "I",  # isort
]

RF103: pyupgrade must be selected
Must select the pyupgrade UP checks. Recommended:

[tool.ruff.lint]
extend-select = [
  "UP",  # pyupgrade
]
This was referenced Mar 10, 2024
Closed
Closed
jaraco added a commit that referenced this issue Aug 2, 2024
@jaraco
Apply isort. Ref #240
e8d011b
jaraco added a commit that referenced this issue Aug 2, 2024
@jaraco
Apply isort. Ref #240
d7ffdb9
@jaraco jaraco mentioned this issue Aug 2, 2024
Closed
2 tasks
jaraco added a commit that referenced this issue Aug 2, 2024
@jaraco
Apply isort. Ref #240
b7ee725
@jaraco jaraco mentioned this issue Aug 2, 2024
Merged
2 tasks
DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/distutils that referenced this issue Aug 3, 2024
@jaraco @DimitriPapadopoulos
Apply isort. Ref pypa#240
7ea7eda
DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/distutils that referenced this issue Aug 3, 2024
@jaraco @DimitriPapadopoulos
Apply isort. Ref pypa#240
0c08cab
@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue Aug 3, 2024
Merged
clrpackages pushed a commit to clearlinux-pkgs/pypi-setuptools that referenced this issue Aug 15, 2024
@fenrus75
pypi-setuptools: Autospec creation for update from version 72.1.0 to …
d5a0806 
…version 72.2.0

Christoph Reiter (6):
      find_library_file: port from doctest to normal test and fix for cygwin
      test_customize_compiler_with_msvc_python: skip for cygwin
      CI: add a job for running tests under MSVC CPython with GCC as the default compiler
      mingw: make get_msvcr() a noop
      venv_install_options: add missing clear_argv fixture
      Remove unused RangeMap

Jason R. Coombs (42):
      👹 Feed the hobgoblins (delint).
      👹 Feed the hobgoblins (delint).
      Adjust expectation to match behavior.
      For consistency, ensure Extension.sources is always a pathlib.Path object and adjust expectations in tests.
      When computing input_opt, ensure src is a string (when it could be a pathlib Path).
      In filelist, allow for self.files to be pathlib objects.
      Revert "Disable cygwin tests for now. Ref pypa/setuptools#3921"
      Simply accept pathlib objects and convert them early for compatibilty with upstream.
      Reword docs on 'Build system requirement' to use imperative voice.
      Add guidance on pinning the upper bound in build-system.requires.
      Pin towncrier in docs build.
      Prefer f-strings
      Need to include 'three' in the input.
      Consolidate str and Path handling.
      Remove r string now that docstring is gone.
      Expand convert_path to also accept pathlib.Path objects.
      👹 Feed the hobgoblins (delint).
      Prefer simply 'pathlib' for import.
      👹 Feed the hobgoblins (delint).
      Extract a singledispatchmethod _copy for handling the copy of each data file.
      Use explicit registration for compatibility with older Pythons.
      Prefer os.PathLike in convert_path
      Convert needs to accept None for Setuptools' sake.
      In test_convert_path, utilize posixpath.join and ntpath.join for maximum compatibility with other libraries.
      Wrap paths in PurePosixPath to ensure that any WindowsPaths don't get backslashes.
      convert_path no longer fails if passed a path with a trailing slash. Instead, trailing slashes are stripped just as they are with pathlib.Path.
      convert_path now converts to a platform-native path.Path, but then calls `.as_posix()` on it.
      Separate test_convert_path into two tests to avoid interactions in monkeypatching os.path.
      Remove expectation that a ValueError is raised for data_files being drive-relative absolute on Windows.
      Simplify convert_path by simply relying on the logic in PurePath.
      Harmonize convert_path tests across Unix and Windows.
      Consolidate convert_path tests and just generate the expected value in a platform-sensitive way. Should fix failures on mingw.
      Harmonize '-shared' parameter for C and C++ in Mingw32CCompiler
      In sysconfig.customize_compiler, initialize ldcxxshared from config vars.
      Refactored customize_compiler to reduce logical branches and extract _add_flags logic.
      Use simple import
      Don't add flags when the value is None, such as when on PyPy, LDCXXSHARED is unset.
      Rely on monkeysession to monkeypatch.
      Apply isort. Ref pypa/distutils#240
      Add news fragment.
      Correct reference in news fragment. Ref #4539
      Bump version: 72.1.0 → 72.2.0

Michael Carlstrom (1):
      Allow path objects

Mridul Seth (1):
      ENH: Extension should be able to accept PathLike sources objects

Samuel Cormier-Iijima (3):
      Distutils C++ support
      Adjust tests further to accommodate C++ support.
      Ignore sysconfig variables for LDCXXSHARED as it appears not to exist on PyPy.

connortann (1):
      [Docs] Minor grammar fix in dependency_management.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce flake8-bugbear (B) and isort (I) ruff rules DimitriPapadopoulos/distutils
1 participant
@DimitriPapadopoulos