Upgrade patchelf to 0.12 #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd think you need to revert the patching portions of #739 as well. |
|
Yes and no - that change was made on the manylinux2014 branch, and this PR is for the master branch. Apologies for not understanding the branch structure here - is this PR unhelpful? |
|
For the record, the reversion has now been done in #741 |
|
This PR does not really address #735 since that issue is arm64-specific. There may be other reasons to update patchelf, so I think it is worthwhile. One for the manylinux1 branch would bring all the branches into sync. |
|
Thanks @radarhere. I also created a PR for manylinux1 to bring all the branches into sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #735