Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document project_urls as an option to setup.py #441

Merged
merged 3 commits into from
Feb 22, 2018

Conversation

phildini
Copy link
Contributor

project_urls is an allowed option to setup() that provides a really nice
place for maintainers to add bug tracker or funding URLs. The hope is that by
documenting the usage, maintainers will be encouraged to add more useful URLs
to their setup.py.

This ticket comes by way of pypa/setuptools#1276 and the corresponding PR in sampleproject has already been merged: pypa/sampleproject#63

`project_urls` is an allowed option to `setup()` that provides a really nice
place for maintainers to add bug tracker or funding URLs. The hope is that by
documenting the usage, maintainers will be encouraged to add more useful URLs
to their setup.py
Copy link
Member

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change generally looks good to me, just a couple of minor changes/additions suggested inline.

::

project_urls={
'Bug Reports': 'https://github.com/pypa/sampleproject/issues',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most projects also use their issue tracker for feature requests, so Bug Reports doesn't feel quite right here. The PEP 459 draft suggested using the generic term Tracker, without saying anything specific about what was being tracked (bug tracker, issue tracker, request tracker, ticket tracker, etc).

'Bug Reports': 'https://github.com/pypa/sampleproject/issues',
'Funding': 'https://donate.pypi.org',
'Say Thanks!': 'http://saythanks.io/to/example',
'Source': 'https://github.com/pypa/sampleproject/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a self-referential link back to this page in order to show an example documentation link:

'Documentation': 'https://packaging.python.org/tutorials/distributing-packages/'

@ncoghlan ncoghlan merged commit beb9775 into pypa:master Feb 22, 2018
@ncoghlan
Copy link
Member

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants