Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose various function in tags publicly #231

Merged
merged 61 commits into from
Nov 25, 2019

Conversation

brettcannon
Copy link
Member

Closes #187 and should open the way for pip to start using packaging.tags.

docs/tags.rst Outdated Show resolved Hide resolved
docs/tags.rst Outdated Show resolved Hide resolved
docs/tags.rst Outdated Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
docs/tags.rst Outdated Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member Author

This should also close #184

@brettcannon
Copy link
Member Author

I will also note that _generic_abi() could probably be changed to return a sequence and leave out "none".

packaging/tags.py Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member Author

OK, I think I have addressed everything at this point. Let me know if you need anything for this PR before I merge it.

Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other minor comment, but I have no problem addressing this as a separate issue.

packaging/tags.py Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member Author

@chrahunt PTAL

@chrahunt
Copy link
Member

LGTM!

@brettcannon brettcannon merged commit 41b0ad5 into pypa:master Nov 25, 2019
@brettcannon brettcannon deleted the expose-tags branch November 25, 2019 18:59
@brettcannon
Copy link
Member Author

Thanks everyone for working on this! I know it was a slog to get through.

@pradyunsg
Copy link
Member

Hurrah! Many thanks for all the work here folks! ^>^

@xavfernandez
Copy link
Member

A new packaging release (20.0 ?) would be lovely to unlock pypa/pip#7354 🙏

@di
Copy link
Member

di commented Jan 2, 2020

@xavfernandez I think we need to merge #221 and #234 first.

@chrahunt
Copy link
Member

chrahunt commented Jan 2, 2020

Only #221 is required to prevent breaking something that currently works in pip. #234 is a change to existing behavior that could be evaluated independently in its own time if needed.

@pradyunsg
Copy link
Member

@chrahunt In that case, I think we can go ahead and make a release.

@pypa/packaging-committers Any concerns with making a release? If not, let's go ahead and make one. :)

@pradyunsg
Copy link
Member

Whoops -- I just saw #252 (which is now crosslinked, so yay?)

docs/tags.rst Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customizing generation of tags
6 participants