Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parentheses for arbitrary operator #353

Closed
wants to merge 2 commits into from

Conversation

gmmephisto
Copy link

Closes: #336

@uranusjr
Copy link
Member

Note that this would break things like name ===1.0;1 and name ===1.0(1), both are valid (non-PEP-440) specifiers. They are likely uncommon, and would be a good compromise to fix #336 IMO without introducing too much complexity. But it may be worthwhile to include a comment explaining the caveats.

@brettcannon
Copy link
Member

I've asked over on the issue people like the solution this PR proposes.

@brettcannon
Copy link
Member

Now that we have a handcrafted parser, I'm going to close this as that's probably the best way to support this situation. Thanks for at least trying, @gmmephisto .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement parser does not support arbitrary equality in legacy parentheses format
3 participants