Codebase modernisation #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should update the codebase to use modern Python 3 features.
This is no longer necessary, since Python 2 support has been dropped.
uranusjr
approved these changes
Oct 11, 2021
brettcannon
approved these changes
Oct 18, 2021
|
I would recommend trying pyupgrade with 3.6 set on the codebase, it's quite nice for this sort of thing. I usually add it to pre-commit. |
|
I've even done this before: #414 |
|
If you look at the branch name, you'll notice a small detail. :P Please feel free to update that PR -- I didn't want to step-on-the-toes of that one, which is why I've not added pyupgrade to pre-commit here. :) |
|
🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should update the codebase to use modern Python 3 features.
Closes #462 by removing the offending code. :)