Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better output on linter failure #478

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Better output on linter failure #478

merged 2 commits into from
Aug 19, 2022

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 29, 2021

When the linter fails, at least in CI, it might not show any output if it just changes things. This is one idea to have more output; another idea could be to add *session.posargs here, and add -- --show-diff-on-failure in just the CI run.

@pradyunsg
Copy link
Member

This is one idea to have more output; another idea could be to add *session.posargs here, and add -- --diff-on-output in just the CI run.

I'd prefer that -- the diff output is annoying when run locally.

@henryiii
Copy link
Contributor Author

Okay, implemented it that way.

@brettcannon brettcannon reopened this Aug 19, 2022
@brettcannon brettcannon merged commit 1280051 into pypa:main Aug 19, 2022
KOLANICH pushed a commit to KOLANICH-libs/packaging that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants