Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: Pin CycloneDX behind the 1.0.0 release #213

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

tetsuo-cpp
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp commented Jan 13, 2022

The v1.0.0 release included a breaking schema change.

pip_audit/_format/cyclonedx.py:36: error: List comprehension has incompatible type List[str]; expected List[VulnerabilityAdvisory]
Found 1 error in 1 file (checked 50 source files)
make: *** [lint] Error 1

The new advisory type requires a URL (which we don't have) so it wasn't immediately obvious what to do about this. So I'm proposing to pin our version behind 1.0.0 while we figure this out.

@di
Copy link
Member

di commented Jan 13, 2022

Let's get a release with this out.

@woodruffw woodruffw merged commit 6893daa into main Jan 13, 2022
@woodruffw woodruffw deleted the alex/cyclonedx-pin branch January 13, 2022 15:34
@woodruffw
Copy link
Member

Pushed out 1.1.2 with this fix.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 17, 2022
## [1.1.2] - 2022-01-13

### Fixed

* A pin on one of `pip-audit`'s dependencies was fixed
  ([#213](pypa/pip-audit#213))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants